chore: intro install-dist module in root
#2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2552 +/- ##
============================================
+ Coverage 56.94% 56.98% +0.04%
Complexity 827 827
============================================
Files 612 612
Lines 49672 49672
Branches 6681 6681
============================================
+ Hits 28284 28304 +20
+ Misses 18572 18558 -14
+ Partials 2816 2810 -6 ☔ View full report in Codecov by Sentry. |
imbajin
reviewed
Jun 6, 2024
pom.xml
Outdated
| @@ -93,6 +93,7 @@ | |||
| <module>hugegraph-server</module> | |||
| <module>hugegraph-pd</module> | |||
| <module>hugegraph-store</module> | |||
| <module>dist</module> | |||
There was a problem hiding this comment.
The module name "hugegraph-dist" is currently taken... Consider renaming after "hugegraph-dist" is renamed to "server-dist".
dosubot
bot
added
size:M
imbajin
reviewed
Jun 10, 2024
VGalaxies
changed the title
install-dist module in root
imbajin
approved these changes
Jun 12, 2024
Comment on lines
-55
to
+61
| initial-store-list: 127.0.0.1:8502 | ||
| initial-store-list: 127.0.0.1:8500 | ||
|
|
||
| raft: | ||
| # The address of the local raft service | ||
| address: 127.0.0.1:8610 | ||
| # The service address of the PD cluster | ||
| peers-list: 127.0.0.1:8610,127.0.0.1:8611,127.0.0.1:8612 | ||
| peers-list: 127.0.0.1:8610 |
There was a problem hiding this comment.
Currently, no side effects have been found. The modification is intended to use org.apache.hugegraph.pd.boot.HugePDServer to quickly start a single node PD.
liuxiaocs7
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install-distmodule in roothugegraph-server/hugegraph-disttoinstall-distapache-hugegraph-incubating-pd/server-xxx